sys.h: Fix __attribute__ usage for non-GCC compilers #884
+28
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 15, 2026
Contributor
Author
|
@gilles-peskine-arm, I hope that this solves your issues with MSVC and IAR. Could you try it out? Btw, feel free to tag @pq-code-package/pqcp-mldsa-native-admin for issues like this in the future. We'll try to help if we have some spare cycles. This time we only saw it coincidentally. |
mkannwischer
force-pushed
the
fix-mld-inline
branch
3 times, most recently
from
61db8f5 to
fb8b926
Compare
hanno-becker
approved these changes
Jan 15, 2026
Contributor
hanno-becker
left a comment
hanno-becker
left a comment
There was a problem hiding this comment.
Thanks @gilles-peskine-arm for noting this, and @mkannwischer for analyzing and fixing. LGTM.
Restructure `MLD_INLINE` and `MLD_ALWAYS_INLINE` into separate blocks, each independently guarded: `MLD_INLINE`: - MSVC: `__inline` - C99 or `inline` macro defined: `inline` - GCC/Clang C90: `__attribute__((unused))` to silence warnings - Other C90: empty `MLD_ALWAYS_INLINE`: - MSVC: `__forceinline` - GCC/Clang C99+: `MLD_INLINE __attribute__((always_inline))` - Other: `MLD_INLINE` (no forced inlining) This fixes two issues: 1. If `inline` was defined as a macro before including sys.h, the MSVC check was bypassed and `__attribute__` was used, causing MSVC failures. 2. For non-MSVC/GCC/Clang compilers like IAR, `__attribute__` was used unconditionally, causing build failures. Also fix typo: `defined(clang)` -> `defined(__clang__)` Signed-off-by: Matthias J. Kannwischer <[email protected]>
hanno-becker
force-pushed
the
fix-mld-inline
branch
from
fb8b926 to
33cac9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure
MLD_INLINEandMLD_ALWAYS_INLINEinto separate blocks,each independently guarded:
MLD_INLINE:__inlineinlinemacro defined:inline__attribute__((unused))to silence warningsMLD_ALWAYS_INLINE:__forceinlineMLD_INLINE __attribute__((always_inline))MLD_INLINE(no forced inlining)This fixes two issues:
inlinewas defined as a macro before including sys.h, the MSVCcheck was bypassed and
__attribute__was used, causing MSVC failures.__attribute__was usedunconditionally, causing build failures.
Also fix typo:
defined(clang)->defined(__clang__)